This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
My assignment is in place. I am in the middle of making corrections as suggested by you and Paolo.Hi Ed! This looks great. It's encouraging to see somebody working on this difficult piece of TR1.
I have a couple of comments in addition to Paolo's feedback.
1) attribution: +// Written by Edward Smith-Rowland based on numerous mathematics books.
A bit more detail, please.
2) namespace macro confusion
this: +_GLIBCXX_BEGIN_NAMESPACE(std) + +_GLIBCXX_BEGIN_NAMESPACE(tr1)
should instead be consistent with the other tr1 headers:
+ namespace std + { +_GLIBCXX_BEGIN_NAMESPACE(tr1)
In general, this looks like it is ready to start being checked in, to
me. Do you have your assignment in place?
Also, what is the plan WRT GSL? Is there a plan for cooperation, or isThe GSL is a great piece of work and I am looking at it as I go. The GSL is in C and only supports double precision. I chose to use template functions to support the three floating point types that TR1 calls for. I like the idea of having a single generic algorithm. With this decision I think there will be just to many differences to support any real immediate sharing. Maybe as I add attributions to the commentary I could note corresponding functions in GSL as appropriate. I think I'll do this.
this just going to be a separate code base? Insights appreciated.
You say:I'm hoping to build a test application or set of applications that will compare the results of TR1 versus GSL.
I think it would be worthwhile to have a GSL-TR1 deathmatch althoughCan you elaborate?
this might not be appropriate for the testsuite.
-benjamin
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |