This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: C++ PATCH: DR150/PR9737
- From: Paolo Carlini <pcarlini at suse dot de>
- To: mark at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Fri, 03 Feb 2006 19:41:57 +0100
- Subject: Re: C++ PATCH: DR150/PR9737
- References: <200602031808.k13I8JQB025635@sethra.codesourcery.com>
Hi Mark,
interesting issue...
The v3 changes are fine with me, only...
>Index: libstdc++-v3/testsuite/testsuite_tr1.h
>===================================================================
>--- libstdc++-v3/testsuite/testsuite_tr1.h (revision 110465)
>+++ libstdc++-v3/testsuite/testsuite_tr1.h (working copy)
>@@ -64,6 +64,18 @@ namespace __gnu_test
> return ret;
> }
>
>+ template<template<typename, unsigned> class Property,
>+ typename Type,
>+ unsigned Uint>
>+ bool
>+ test_property(typename Property<Type, Uint>::value_type value)
>+ {
>+ bool ret = true;
>+ ret &= Property<Type, Uint>::value == value;
>+ ret &= Property<Type, Uint>::type::value == value;
>+ return ret;
>+ }
>
>
... can you add a one-line comment before the new test_property overload
stating that is used for testing tr1/type_traits/extent? Just as a
reminder that maybe those testing facilities can be cleaned up a bit...
Thanks a lot,
Paolo.