This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: LDFLAGS handling in V3
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 02 Jan 2006 16:37:05 -0200
- Subject: Re: PATCH: LDFLAGS handling in V3
- References: <42E927F8.2090004@codesourcery.com> <orpst29142.fsf@livre.redhat.lsd.ic.unicamp.br> <42E98339.2070803@codesourcery.com> <42E9AD58.5020809@codesourcery.com> <orbr25qcci.fsf@livre.oliva.athome.lsd.ic.unicamp.br> <43461472.2030801@codesourcery.com> <orzmpl2zxv.fsf@livre.oliva.athome.lsd.ic.unicamp.br> <43B62292.1080300@codesourcery.com> <20060101170856.GA5309@nevyn.them.org> <43B81D1D.2070103@codesourcery.com> <20060101183115.GA6269@nevyn.them.org> <43B8361C.9010609@codesourcery.com>
On Jan 1, 2006, Mark Mitchell <mark@codesourcery.com> wrote:
> Daniel Jacobowitz wrote:
>> I was suggesting passing a transformed LDFLAGS to the subdirectory.
>> Probably based on grepping configure.in or configure.ac for
>> '^A[CM]_PROG_LIBTOOL'.
> If the consensus is that this is better, we can do that. But, how do
> we know the subdirectory doesn't want the unmodified LDFLAGS for some
> other purpose?
Adding -Xcompiler to LDFLAGS is just wrong, since -Xcompiler is not a
valid link-time flag for the compiler driver. That's why we came up
with LTLDFLAGS. So, yes, I disagree with Daniel's suggestion, and
stand by my earlier suggestion.
> Or, do you want to just pass LTLDFLAGS to all
> subdirectories?
That would be fine, but only if we know subdirectories don't want to
tweak it, and want to stop them from doing so. I don't think we want
to go that far.
>> Instead, it should be $(shell $(SHELL) .../script $(LDFLAGS))
>> so that $(SHELL) is used to run the shell script.
> OK, consider that change made.
Ok with the change, unless DanJ further objects to this approach.
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}