This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] testsuite/25193 libstdc++ testsuite fails on cygwin
- From: Christopher Faylor <me at cgf dot cx>
- To: libstdc++ at gcc dot gnu dot org, "Billinghurst, David (CALCRTS)" <david dot billinghurst at comalco dot riotinto dot com dot au>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 6 Dec 2005 11:10:37 -0500
- Subject: Re: [patch] testsuite/25193 libstdc++ testsuite fails on cygwin
- References: <026DCC31AB859648A6F16C0E5CD2580D056C39@calttsv025.cal.riotinto.org>
On Thu, Dec 01, 2005 at 01:44:31PM +1100, Billinghurst, David (CALCRTS) wrote:
>libstdc++ testsuite fails on cygwin while trying to delete a file.
>Similar patches have been applied in other parts of the gcc testsuite
>over the last year or so.
>
>For example http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00146.html
>
>I will commit as obvious after another round of testing.
>
>2005-12-01 David Billinghurst (David.Billinghurst@riotinto.com)
>
> PR testsuite/25193
> * testsuite/lib/libstdc++.exp (libstdc++-dg-test): Catch
> error if file cannot be deleted.
FWIW, this patch seems like an obvious fix to me.
cgf
>Index: libstdc++-v3/testsuite/lib/libstdc++.exp
>===================================================================
>--- libstdc++-v3/testsuite/lib/libstdc++.exp (revision 107682)
>+++ libstdc++-v3/testsuite/lib/libstdc++.exp (working copy)
>@@ -264,7 +264,7 @@
> set output_file "./[file rootname [file tail $prog]].exe"
> # This is the only place where we care if an executable was
> # created or not. If it was, dg.exp will try to run it.
>- remote_file build delete $output_file;
>+ catch { remote_file build delete $output_file }
> }
> default {
> perror "$do_what: not a valid dg-do keyword"