This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] : Tiny change to _NullClass in <tr1/tuple>
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: caj at cs dot york dot ac dot uk (chris jefferson)
- Cc: libstdc++ at gcc dot gnu dot org (libstdc++), gcc-patches at gcc dot gnu dot org
- Date: Mon, 28 Nov 2005 12:59:38 -0500 (EST)
- Subject: Re: [patch] : Tiny change to _NullClass in <tr1/tuple>
>
> This is a multi-part message in MIME format.
> --------------000306020509010601040104
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
> Content-Transfer-Encoding: 7bit
>
> This very tiny patch just removed the body of _NullClass, which is used
> as a placeholder in tr1::tuple
>
> This type should never be seen by users, however, I found someone who
> was (accidentally) making objects of this type (by accessing the 3rd
> type of a tuple of length 2).
>
> Bootstrapped on ppc-darwin.
>
> --------------000306020509010601040104
> Content-Type: application/text; x-mac-type="54455854"; x-mac-creator="0";
> name="ChangeLog"
> Content-Transfer-Encoding: base64
> Content-Disposition: inline;
> filename="ChangeLog"
First, can you make sure that this is attached as plain/text, next time:
Usually I just put the changelog to be part of the message body itself.
And attach the patch.
>2005-11-28 Chris Jefferson <chris@bubblescope.net>
>
> * include/tr1/tuple (_NullClass) : Remove body, as this
> class is never instantiated.
Second instantiated is the wrong term here.
Maybe the following is better:
Change to a forward declaration as it is never fully used.
Or something like that.
-- Pinski