This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] 4.0 fix for libstdc++/23871

Janis Johnson wrote:

OK for the 4.0-branch after it opens?


Ok, but...

* include/bits/ostream.tcc (operator<<(long), operator<<(long long)):
Avoid using || with integers.


please change this to "Adjust logic", or something of similar meaning: it's not only a type-correctness issue, it's first and foremost a logic issue, as the run tests demonstrate.

Thanks,
Paolo.

P.S. At your ease, you may add the compile test to mainline: as a general policy, in mainline we have a superset of the testcases in the release branches.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]