This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] 4.0 fix for libstdc++/23871

Hi Janis,

>Sorry, I was running the tests by hand outside of the testsuite and
>_GLIBCXX_ASSERT was not set.  With that set, the tests fail for 4.0 with
>and without my patch, so apparently the tests require parts of the patch
>that I did not backport; my patch has only the changes to std_ostream.h,
>which are needed to allow the PR's test case to compile.
>  
>
I see, thanks.

The problem is that the very same flaw (& instead of ==, basically) was
present also in ostream.tcc, in two places, for operator<<(long __n) and
operator<<(long long __n).

For 4.0 I would rather prefer adjusting only that (in addition to the
std_ostream.h hunk), and not touching also the locale classes. Are you
willing to test that complete change?

Thanks,
Paolo.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]