[Patch] libstdc++/23632

[Paolo Carlini <pcarlini at suse dot de>]

Hi,

another case of missing const: submitter believes we should add a const
version of operator[] but in my opinion just const-ifing the existing
one is perfectly ok. Anyone disagreeing?

Tested x86-linux.

Paolo.

//////////////////

2005-08-30  Paolo Carlini  <pcarlini@suse.de>
	    Kaspar Fischer <fischerk@inf.ethz.ch> 

	PR libstdc++/23632
	* include/bits/stl_bvector.h (_Bit_iterator::operator[],
	_Bit_const_iterator::operator[]): Const-ify.
	* testsuite/23_containers/vector/bool/23632.cc: New.

Index: include/bits/stl_bvector.h
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/include/bits/stl_bvector.h,v
retrieving revision 1.44
diff -u -r1.44 stl_bvector.h
--- include/bits/stl_bvector.h	30 Aug 2005 15:49:15 -0000	1.44
+++ include/bits/stl_bvector.h	30 Aug 2005 16:27:21 -0000
@@ -259,7 +259,7 @@
     }
 
     reference
-    operator[](difference_type __i)
+    operator[](difference_type __i) const
     { return *(*this + __i); }
   };
 
@@ -345,7 +345,7 @@
     }
 
     const_reference
-    operator[](difference_type __i)
+    operator[](difference_type __i) const
     { return *(*this + __i); }
   };
 
Index: testsuite/23_containers/vector/bool/23632.cc
===================================================================
RCS file: testsuite/23_containers/vector/bool/23632.cc
diff -N testsuite/23_containers/vector/bool/23632.cc
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ testsuite/23_containers/vector/bool/23632.cc	30 Aug 2005 16:27:21 -0000
@@ -0,0 +1,40 @@
+// Copyright (C) 2005 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 2, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING.  If not, write to the Free
+// Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+// USA.
+
+// { dg-do compile }
+
+#include <vector>
+
+// libstdc++/23632
+void test01()
+{
+  std::vector<bool> v(100);
+  const std::vector<bool>::iterator fu = v.begin();
+  if (!fu[0])
+    fu[0] = true;
+
+  const std::vector<bool>::const_iterator cfu = v.begin();
+  if (cfu[0])
+    ;
+}
+
+int main()
+{
+  test01();
+  return 0;
+}