This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] libstdc++/23465
- From: Paolo Carlini <pcarlini at suse dot de>
- To: chris jefferson <caj at cs dot york dot ac dot uk>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Wed, 24 Aug 2005 13:13:49 +0200
- Subject: Re: [Patch] libstdc++/23465
- References: <430BAA21.1040506@suse.de> <430C51CA.6040007@cs.york.ac.uk>
chris jefferson wrote:
>I have a feeling the copy_code_from should possibly be:
>this->copy_code(n, *tail);
>
>It's purpose seems to be for when the hash value is cached (which I'm
>not sure is ever done in any of the standard containers), and
>m_allocate_node doesn't copy this value. For the specialisation where
>the hashed value isn't stored in each node, this->copy_node is just
>defined to be an empty function.
>
>
Yes, I think you are right. I'm going to change the patch as you suggest
and regtest again. Later we can further tweak and improve this area. As
you observe, the (tr1)standard containers don't cache anything,
therefore we are on the safe side anyway.
By the way, long term, we have to do something about the additional
template parameter at issue (cache_hash_code) : implementations are not
allowed to add templete parameters!
Paolo