This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, libstdc++] libstdc++ pb_assoc testcase fix

From: Paolo Carlini <pcarlini at suse dot de>
To: Jonathan Wakely <cow at compsoc dot man dot ac dot uk>
Cc: David Edelsohn <dje at watson dot ibm dot com>, libstdc++ at gcc dot gnu dot org
Date: Thu, 07 Jul 2005 00:48:32 +0200
Subject: Re: [PATCH, libstdc++] libstdc++ pb_assoc testcase fix
References: <200507062054.j66Kst034042@makai.watson.ibm.com> <20050706215409.GA57871@compsoc.man.ac.uk>

Jonathan Wakely wrote:

>On Wed, Jul 06, 2005 at 04:54:55PM -0400, David Edelsohn wrote:
>
>>	A libstdc++ testcase for pb_assoc uses the type map_t, conflicting
>>with that same type in system headers.  The following patch changes the
>>name to tree_map_t to make it more unique.  I can change it to something
>>else more unique if there are other preferences.
>>    
>>
>Am I right in thinking that any POSIX header is allowed to define any
>name ending in _t, possibly as a macro, so maybe map_type or
>tree_map_type would be even better?  That is also consistent with the
>standard library's size_type, value_type etc.
>  
>
Also ok with me (notice that we are talking about *a testcase* therefore
consistency with the standard library names doesn't seem really
relevant. Ok, no more nitpicking for today ;)

Paolo.

References:
- [PATCH, libstdc++] libstdc++ pb_assoc testcase fix
  - From: David Edelsohn
- Re: [PATCH, libstdc++] libstdc++ pb_assoc testcase fix
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]