This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Apply DR434 resolution to <debug/bitset>
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Jonathan Wakely <cow at compsoc dot man dot ac dot uk>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 06 May 2005 12:10:22 +0200
- Subject: Re: [patch] Apply DR434 resolution to <debug/bitset>
- References: <20050506095444.GB17135@compsoc.man.ac.uk>
Jonathan Wakely wrote:
>Found this while looking at the vector<bool> issue I posted earlier.
>
>The resolution to DR434 was not applied to <debug/bitset> which causes
>testsuite/23_containers/bitset/to_string/1.cc to FAIL in debug mode.
>
>The attached patch fixes the FAIL on 4.0 and mainline, OK for both?
>(DR434 resolution is not on the 3.4 branch)
>
>
Yes, it's ok.
By the way, what happened of that discussion about debug-pedantic vs
basic_string? Shall we have a consistent policy about that? In any case,
I don't think this is a case where that distinction is important, but if
we (meaning, at least, me and you ;) really want zero failures in
debug-mode we should start telling apart testcases having to do with
details of our implementation from testcases simply enforcing the letter
of the standard.
>Should I use the DR ChangeLog format like this?
>
>
Seems ok, like mine ;)
>I'm not sure if this patch follows C++STYLE correctly, I'll revise it if
>there's a preferred way to break the template arguments in the return
>value.
>
>
Seems also ok, like mine ;)
Paolo.