Re: [patch] : Fix operator+ in random_access_iterator_wrapper

[Paolo Carlini <pcarlini at suse dot de>]

Paolo Carlini wrote:

>Chris Jefferson wrote:
>
>>Just as a brief heads-up (I meant to attach this to my previous mail).
>>Even after these two patches are applied, there is still one testsuite
>>failure with concept checks turned on (25_algorithms/unique/moveable.cc).
>>    
>>
Chris, I'm committing both your patches (to v7-branch), both seem
straightforward to me. Notice, however, that, besides unique, I'm still
seeing also the failure of swap_ranges/check_type.cc. The below is the
error:

/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:
In member function 'void
__gnu_cxx::_Mutable_ForwardIteratorConcept<_Tp>::__constraints() [with
_Tp = __gnu_test::forward_iterator_wrapper<X>]':
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:62:  
instantiated from 'void __gnu_cxx::__function_requires() [with _Concept
=
__gnu_cxx::_Mutable_ForwardIteratorConcept<__gnu_test::forward_iterator_wrapper<X>
>]'
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/stl_algo.h:664:  
instantiated from '_ForwardIterator2 std::swap_ranges(_ForwardIterator1,
_ForwardIterator1, _ForwardIterator2) [with _ForwardIterator1 =
__gnu_test::forward_iterator_wrapper<X>, _ForwardIterator2 =
__gnu_test::forward_iterator_wrapper<X>]'
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch/gcc/libstdc++-v3/testsuite/25_algorithms/swap_ranges/check_type.cc:41:  
instantiated from here
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch/gcc/libstdc++-v3/testsuite/25_algorithms/swap_ranges/check_type.cc:31:
error: 'void X::operator=(const X&)' is private
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:493:
error: within this context
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:
In member function 'void __gnu_cxx::_ConvertibleConcept<_From,
_To>::__constraints() [with _From = X, _To = X]':
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:62:  
instantiated from 'void __gnu_cxx::__function_requires() [with _Concept
= __gnu_cxx::_ConvertibleConcept<X, X>]'
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/stl_algo.h:668:  
instantiated from '_ForwardIterator2 std::swap_ranges(_ForwardIterator1,
_ForwardIterator1, _ForwardIterator2) [with _ForwardIterator1 =
__gnu_test::forward_iterator_wrapper<X>, _ForwardIterator2 =
__gnu_test::forward_iterator_wrapper<X>]'
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch/gcc/libstdc++-v3/testsuite/25_algorithms/swap_ranges/check_type.cc:41:  
instantiated from here
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch/gcc/libstdc++-v3/testsuite/25_algorithms/swap_ranges/check_type.cc:30:
error: 'X::X(const X&)' is private
/home/paolo/Gcc/cvs-dirs/libstdcxx_so_7-branch-build/i686-pc-linux-gnu/libstdc++-v3/include/bits/boost_concept_check.h:223:
error: within this context

Paolo.