Re: PATCH: Fix "make install"

[Benjamin Kosnik <bkoz at redhat dot com>]

> It's not particularly in the spirit of DejaGNU to print out information 
> about passing tests.  However, it's certainly possible, and I can 
> arrange that if you like.  (It would come out mixed in with the normal 
> DejaGNU output stream.)  By verbose output, do you mean the output of 
> "abi_check --verbose" or merely the pseudo-DejaGNU summary it prints at 
> the end?

I was thinking of the summary. However, I can live with the present
abbreviated PASS/FAIL form.

> > I was expecting:
> > 
> >                === libstdc++ check-abi Summary ===
> > 
> > # of added symbols:              50
> > # of missing symbols:            0
> > # of incompatible symbols:       0
> 
> DejaGNU isn't going to be able to do that.  What would be possible would 
> be to have a separate test for each symbol in the baseline file, and 
> then, for any that were missing or had the wrong size, you would get 
> something like:
> 
> FAIL: _Zsomething: Symbol has wrong size.

Doing this, and printing out FAIL lines for just missing or incompatible
would probably be the best best, long term. However, knowing that
symbols were added and correctly versioned between releases is important
too, because then we know that the minor version numbers should be
bumped. Anyway.

The problem with this approach is the summary, although an out-right
hack, has a defined minimum/maximum length. If we were to go to the
approach of one symbol/one potential line of output, if the baselines
are out of sync then the generated output will quickly become
overwhelming and annoy people. So, let's punt for the time being.

> That is because now it's all part of one testsuite.  For example, if you 
> "make current_symbols.txt" (which we could also have the testuite do, if 
> you like), and then do "make check" the ABI test will be run as part of 
> "make check", in addition to the customary tests.

Let's try to keep the changes as small as possible.

Let's just try to fix what Janis said was broken. If your patch, as
posted, fixes it, then I'm ok with it.

I can deal with the rest of it when I have more time.

-benjamin