This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: Build test .po files during test runs
> If you're willing to do a complete transition at this point, we can just
> remove LOCALEDIR from the tests, and replace that "." directly in the
> code. I'd be happy with that, but that will mean that check_compile
> will not work, unless you have already run the tests with "make check",
> because it is "make check" that will actually create the message
> catalogs. (That same issue would arise with the patch to check_compile
> that you suggested.)
This usage is ok with me.
> I think a complete transition would actually involve all of the
> following changes:
>
> 1. The patch I posted to make DejaGNU create the .mo files, but without
> the setting of LOCALEDIR, as that will no longer be necessary.
>
> 2. Modify the tests that use LOCALEDIR to just hard-code ".".
>
> 3. Remove the rules in po/Makefile.am that create the .mo files, as this
> is now done by DejaGNU.
>
> 4. Modify testsuite_flags.in to remove the -DLOCALEDIR setting.
>
> 5. Modify acinclude.m4 to remove glibcxx_localedir.
Sounds good to me.
> I'm happy to prepare a patch that does all of 1-5 above, if you would
> prefer that. Personally, I'd prefer to check in my current patch as
> posted, and then follow up with a patch to do 2-5, but I'm happy to
> batch it all together, if that's what you'd prefer.
I'd rather you do this all together.
-benjamin