This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR libstdc++/19510: Uninitialized variable in some iterators


Paolo Carlini <pcarlini@suse.de> writes:

| >Btw, the initialization is missing in 3.4, too. But the warning is not
| >triggered. Should the patch be applied there, too?
| >
| Hummm, I don't feel strongly, but maybe we can avoid fiddling with
| this old-good code on 3_4-branch, since the warning will never show-up.

But it is buggy code!
Absence of warning is no indication that that things are OK.
There is no reason not apply the fix when we do know that:
  (1) the current code is buggy;
  (2) the fix is trivial and safe

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]