This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: First patch to simplify <algorithm>
On Mon, Dec 06, 2004 at 12:03:54AM +0100, Gabriel Dos Reis wrote:
> Jonathan Wakely <cow@compsoc.man.ac.uk> writes:
>
> | > What this means is that adjacent_find() (both overloads) should
> | > probably be splitted into two pieces:
> | >
> | > (1) __do_adjacent_find() -- better names welcome :-)
> | > Does the core job; no concept checking.
> | > (2) both adjacent_find() do their concept checking, then move on
> | > calling __do_adjacent_find() to do the real job.
[snip]
> | This might be overkill,
>
> What precisely is overkill about it? Could you articulate?
> (You mention runtime overhead but that is just one axis which is not
> being disputed here).
Mostly that it's more work - sunday making me think lazily :)
> | Does splitting them buy something I'm missing?
>
> Get the code straight. Which is all this is about.
Sure. I was being curious rather than critical.
jon
--
"We are all in the gutter, but some of us are looking at the stars."
- Oscar Wilde