This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Fix PR 17741
- From: Paolo Carlini <pcarlini at suse dot de>
- To: Chris Jefferson <caj at cs dot york dot ac dot uk>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Thu, 28 Oct 2004 17:53:22 +0200
- Subject: Re: Fix PR 17741
- References: <41810FFE.5090509@cs.york.ac.uk>
Chris Jefferson wrote:
PR 17741 is a simple problem, where the specialisations of find and
find_if have not been uglified. This simple patch fixes it.
Tested on x86/linux.
Hi Chris.
I have two comments of the type once-and-for-all ;) ...
1- Please follow our conventions for the ChangeLog entry (just have
a look to the file)
2- Please use diff -u (-p unfortunately is not very useful for C++)
and typically -R (again, just have a look to the past postings for the
details)
... and two more, specific to this patch:
3- Do you actually have a testcase or not? ;)
4- In my opinion, this kind of change is more suited for v7-branch.
Paolo.