Re: [Patch] bitmap_allocator.

[Dhruv Matani <dhruvbird at gmx dot net>]

On Wed, 2004-10-13 at 19:58, Paolo Carlini wrote:
> Dhruv Matani wrote:
> 
> >Paolo, is the patch Ok?
> >  
> >
> Yes, looks rather good! The build completed succesfully (the *first time*
> in many months ;) 

:-)


> both on x86 and on x86_64. I'm finishing regtesting

Thanks! I still can't get make check working! Maybe because of the older
version of dejaGNU? I'll try updating that too.

> and then I will also test on ia64. If everything goes well, we can commit
> it tomorrow, if nobody objects indeed, in particular to the linker-map
> additions...
> 
> Benjamin?
> 
> Paolo.
> 
> P.S. There is minor nit: a few unused variable warnings during the build,
> will fix that before the commit.

Actually, I wanted your advice on that.
What I'm doing is instead of using inline functions, I'm using MACROS,
so to typecheck the variables passed, I perform useless assignments
inside the macro so, something like:

inline void foo(int* pint)
{
// stuff;
}

is converted to:

#define _DO_STUFF(_PINT) \
{ \
int* __dummy = _PINT; // Check whether _PINT is actually a int*! \
//stuff; \
}

While I'm not entirely happy with this, I'll try converting it back to
the inline functions and see what happens.

-- 
        -Dhruv Matani.
http://www.geocities.com/dhruvbird/

The price of freedom is responsibility, but it's a bargain, because
freedom is priceless. ~ Hugh Downs