This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: V3 patch causes EH failures in ILP32 mode

You Wrote

>> Well, I added these so that -Weffc++ could be used in CXXFLAGS while
>> building libstdc++.  This was a longstanding issue w/ v3 that was an
>> annoyance to several C++ maintainers (myself included, naturally!).
>
> Ugh.  Do you really think this kind of change is worth it?

I do not; but Benjamin already knows my opinion on that matter.

>  I'm all for
> Scott Meyers, but now every time we add a data member we've got to
> remember to update these functions...

Exactly.  Did you say abstraction?

> I would advise against making these kinds of functions explicit, except
> when necessary.

Amen.

I'm of the opinion that -Weffec++ must be abolished.

-- Gaby
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]