[patch] testsuite file fails concept-checks

[Jonathan Wakely <cow at compsoc dot man dot ac dot uk>]

This patch is required to run the testsuite with --enable-concept-checks.

The __attribute__ syntax used in boost_concept_check.h is not valid in
3.4, so compiling with -Wsystem-headers produces lots of warnings like:

    /data/development/jw/gcc/3.4/bin/../lib/gcc/i386-unknown-freebsd4.8/3.4.1/../../../../include/c++/3.4.1/bits/boost_concept_check.h:
    In member function `void
    __gnu_cxx::_CopyConstructibleConcept<_Tp>::__const_constraints(const
    _Tp&)':
    /data/development/jw/gcc/3.4/bin/../lib/gcc/i386-unknown-freebsd4.8/3.4.1/../../../../include/c++/3.4.1/bits/boost_concept_check.h:197:
    warning: attributes after parenthesized initializer ignored

Should I file a bug report for this?

It's a semi-serious regression for --enable-concept-checks since you can't
use "g++ -Wsystem-headers -Werror"

Also...

The simple struct used as map::key_type in one of the testsuite files is
not LessThanComparable so fails the concept-checks.


2004-05-17  Jonathan Wakely  <redi@gcc.gnu.org>

        * include/bits/boost_concept_check.h: Fix old attribute syntax.
	* testsuite/23_containers/map/modifiers/swap.cc: Define operator<
	to pass concept-checks.

Tested with --enable-concept-checks on both x86_64/linux and x86/freebsd,
where it fixes FAILs in 17_intro/headers.cc and
23_containers/map/modifiers/swap.cc

I'm still getting other FAILs, particularly on FreeBSD, but I don't
think they're related to this. I'll investiate further tonight.

OK to commit? Mainline and 3.4?

jon


-- 
"All human evil comes from this: a man's being unable to sit still in a room."
	- Pascal

Attachment: libstdc++-concept_checks_testsuite.patch
Description: Text document