This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
RE: [Patch] Fix libstdc++/15002 (continued)
- From: Pétur Runólfsson <peturr02 at ru dot is>
- To: "Paolo Carlini" <pcarlini at suse dot de>,"libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 23 Apr 2004 14:45:09 -0000
- Subject: RE: [Patch] Fix libstdc++/15002 (continued)
Paolo Carlini wrote:
> Pétur, do you like the final result?
Yes :-)
> Regtesting is OK,
Hmmm... the existing tests for getline all seem to use stringbuf. This
means that getline will always go exactly once through the loop, and
always take the if (...) branch. It's probably a good idea to add a new
test.
There is an unbuffered streambuf that could be used to test this in
testsuite/27_io/basic_istream/extractors_other/char/9424-in.cc
I'm not sure how much you need to worry about people specializing
basic_streambuf. After all, the only reason __copy_streambufs works
is because it is a friend of basic_streambuf, and I haven't seen
many peoply complaining.
Regards,
Petur
P.S. Here is a simple way to turn protected access into public without
using friendship, from Andrei Alexandrescu:
http://groups.google.com/groups?q=LockSmith+%2Bgroup:comp.lang.c%2B%2B.moderated&hl=is&lr=&ie=UTF-8&oe=UTF-8&selm=sg6ouhi2l6e32%40news.supernews.com&rnum=1