This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Add TPF config support to libstdc++
- From: Ulrich Weigand <weigand at i1 dot informatik dot uni-erlangen dot de>
- To: pcarlini at unitus dot it (Paolo Carlini)
- Cc: weigand at i1 dot informatik dot uni-erlangen dot de (Ulrich Weigand), libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, darcypj at us dot ibm dot com
- Date: Fri, 19 Dec 2003 02:38:25 +0100 (CET)
- Subject: Re: [PATCH] Add TPF config support to libstdc++
Paolo Carlini wrote:
> Hi Ulrich,
>
> >+ // NB: Offsets into ctype<char>::_M_table force a particular size
> >+ // on the mask type. Because of this, we don't use an enum.
> >+ typedef unsigned short mask;
> >+ static const mask upper = _ISupper;
> >+ static const mask lower = _ISlower;
> >+ static const mask alpha = _ISalpha;
> >+ static const mask digit = _ISdigit;
> >+ static const mask xdigit = _ISxdigit;
> >+ static const mask space = _ISspace;
> >+ static const mask print = _ISprint;
> >+ static const mask graph = _ISgraph;
> >+ static const mask blank = _ISblank;
> >+ static const mask cntrl = _IScntrl;
> >+ static const mask punct = _ISpunct;
> >+ static const mask alnum = _ISalnum;
> >
> First blush, the entries for 'graph' and 'alnum' look incorrect (see 22.2.1)
> and at odds with the corresponding entries for all the other OSes.
>
> We have testcases for this in mainline, and in particular I would be
> *very* surprised if testsuite/22_locale/ctype_base/11844.cc actually
> passes...
Hmmm. I *suspect* what happened here is that PJ modeled TPF on
a version of the Linux file from before your last change went in ...
But I'm not really familiar with TPF internals so I'll defer to
the TPF folks here. PJ?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de