Re: [Patch draft] Fix libstdc++/8610

[Andreas Jaeger <aj at suse dot de>]

Paolo Carlini <pcarlini@suse.de> writes:

> Hi!
>
> So, here comes my first draft. Everything seems to work :), but I
> encourage your feedback for refining it. For instance, perhaps I'm
> being naive in checking if a value passed to 'lseek' doesn't
> overflow off_t like this:
>
>     if (__off != static_cast<off_t>(__off))
>
> ???
> It works, but probably we can do better...
>
> Also, is it safe to assume that a libc making available lseek64
> does also provide fopen64?

For both you need to define -D_LARGEFILE_SOURCE64 on glibc, otherwise
the header will not make the prototypes visible.  I don't think this
is done yet and therefore I expect that you get warnings that there's
no prototype for these functions...

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature