This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Fix libstdc++/12352

From: Paolo Carlini <pcarlini at unitus dot it>
To: Pétur Runólfsson <peturr02 at ru dot is>
Cc: Gabriel Dos Reis <gdr at integrable-solutions dot net>, libstdc++ at gcc dot gnu dot org, Benjamin Kosnik <bkoz at redhat dot com>
Date: Fri, 26 Sep 2003 01:14:28 +0200
Subject: Re: [Patch] Fix libstdc++/12352
References: <07D05A69A3D0C14FAEA60C3ACE8E5564028F55CE@mail.ru.is>

Pétur Runólfsson wrote:

Gabriel Dos Reis wrote:

| Tested x86-linux. Do you like it?

It certainly is an improvement. Thanks. I was wondering whether that should not just use the traditional RAII in form of objects construction/destruction (a la sentry), instead of doing it manually.... Just thinking loudly...

I agree.
In any case, this hunk isn't needed, because there is nothing in
the try block that can throw:

Thanks for your reviews.

Therefore, if nobody objects, for the time being I will test and commit a variant of what I have posted (without the silly hunk for the placement new allocations, thanks Pétur!) to close the PR, then will look into more radical changes...

Paolo.

References:
- RE: [Patch] Fix libstdc++/12352
  - From: Pétur Runólfsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]