This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Weird testsuite behaviour


> I just found out the hard way that if a testcase uses
> { dg-options "..." } then _GLIBCXX_ASSERT is not defined by default
> for that testcase.

Yes, this is annoying and was a known problem to me (as I was the one
that kludged ./thread/pthread7-rope.cc into that regime).

> It seems to me that either -D_GLIBCXX_ASSERT should be added
> unconditionally in normal.exp, or assert should be used by default
> in testsuite_hooks.h with a switch (say, _GLIBCXX_NO_ASSERT) to
> turn it off.
>
> Does this make sense?

Your ideas make sense.  I don't know what is best.  Typically, I'd
vote for no change in that case but I hereby vote "don't care".  I
guess post the patch.  If it improves things, someone will approve it.

Loren


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]