Re: [PATCH] Fix PR11784 - atomic __exchange_and_add() broken for ColdFire targets

[Phil Edwards <phil at jaj dot com>]

On Tue, Aug 05, 2003 at 04:31:33PM +0200, Bernardo Innocenti wrote:
> On Monday 04 August 2003 05:43, Phil Edwards wrote:
> >
> >     PR libstdc++/11784
> >     * config/cpu/m68k/atomicity.h .......
> 
> Sorry, I knew... One question: are there any prefixes other than
> c++/ and libstdc++/? Where is the complete list of prefixes?

The prefixes are just the possible GNATS/Bugzilla categories.  The list
has grown since we switched from GNATS to Bugzilla.  If you go to
http://gcc.gnu.org/bugzilla and do a query, the Categories box will show
you the possible entries.

(Of course, the category is technically redundant in the presence of the
bug number itself, but it definitely helps the humans.  *grin*)


> > > -#endif /* atomicity.h */
> > > +#endif /* !_BITS_ATOMICITY_H */
> >
> > If you're going to use comments in the final endif, please make it use
> > the same name at the top of the header.  In this case,
> > _GLIBCXX_ATOMICITY_H.
> 
> Sorry, it used to be _BITS_ATOMICITY_H back in gcc 3.3.1.
> 
> Shall I send another patch or will the committer take care of this?

Sorry, I missed that your patch was against the 3.3.1 sources.  Which raises
a question:  did you intend for the patch to go in the 3.3 branch, or just
the trunk?  I looks to be a pure improvement, not a bugfix, so I don't know
that it qualifies for the branch at this point.


Phil

-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it.
    - Brian W. Kernighan