This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libstdc++ PATCH] libstdc++ debug mode (fourth try)


Hmmm.

- right before you check this in, send to gcc-patches. In the meantime,
drop it from your cc list.

- some documentation tweaks, see attached

- safe_iterator.tcc copyright info needs to match other files

- _GLIBCXX_STRINGIFY used once, please consolidate and remove

- _GLIBCXX_RELEASE_CLASS(Name) (and similarly _GLIBCXX_DEBUG_CLASS) can
incorporate the Name, removing duplication, please change to

#  define _GLIBCXX_RELEASE_CLASS(_N) __attribute__((__link_name__(#_N))) _N

- replace _GLIBCXX_DEBUG_NAMESPACE_CLOSE with }, kill the macro

- change

#  define _GLIBCXX_DEBUG_NAMESPACE_OPEN(_Ns) namespace __gnu_debug {

to

#  define _GLIBCXX_NAMESPACE_DEBUG(_Ns) __gnu_debug 

and modify the code to be

namespace _GLIBCXX_NAMESPACE_DEBUG
{

- for include/debug/vector, can't you just use a using declaration
instead of re-defining vector in namespace __gnu_debug (and we'll just
say in the docs that __gnu_debug::vector cannot be specialized?)

-benjamin


Attachment: p.20030805-1
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]