This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Move streambuf::_M_mode to filebuf and stringbuf
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: Nathan Myers <ncm-nospam at cantrip dot org>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Sun, 29 Jun 2003 18:59:08 +0200
- Subject: Re: [Patch] Move streambuf::_M_mode to filebuf and stringbuf
- References: <3EFF15D8.10507@unitus.it> <20030629165520.GF7257@tofu.dreamhost.com>
Nathan Myers wrote:
@@ -214,6 +221,7 @@
{
this->close();
_M_buf_size = 0;
+ _M_mode = ios_base::openmode(0);
_M_last_overflowed = false;
}
One question -- I know you just copied what was here, but -- why
are we re-initializing data members in the destructor? Let's
trash all three assignments.
You are right, of course. I was also preparing something else and in the
rush didn't consider attentively the issue. Will do the change and
commit tomorrow.
Paolo.