This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Move streambuf::_M_mode to filebuf and stringbuf


On Sun, Jun 29, 2003 at 06:37:44PM +0200, Paolo Carlini wrote:
> the below, as per Nathan's private indication, moves streambuf::_M_mode
> to its proper places (where it's actually used, that is).

Thanks Paolo.

> @@ -214,6 +221,7 @@
>        {
>  	this->close();
>  	_M_buf_size = 0;
> +	_M_mode = ios_base::openmode(0);
>  	_M_last_overflowed = false;
>        }

One question -- I know you just copied what was here, but -- why 
are we re-initializing data members in the destructor?   Let's
trash all three assignments.  

Nathan Myers
ncm-nospam@cantrip.org


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]