Re: Comments on check-abi

[Andreas Jaeger <aj at suse dot de>]

Benjamin Kosnik <bkoz@redhat.com> writes:

>>  Currently check-ABI is only run for the default ABI, the test is not
>>  multi-lib aware.
>>
>>  I run on x86_64-linux-gnu the testsuite with
>>   RUNTESTFLAGS="--target_board 'unix{-m32,}'" 
>>  in the environment to test both 32-bit x86 and 64-bit x86-64 code
>>  generation.  This gives 32/ subdirectories when building and the
>>  testsuite handles this fine.
>>
>>  My suggestion is to add MULTISUBDIR ("32/" for AMD64) to baseline_file in
>>  aclocal.m4 and then create the special ABI and let us test it
>
> Hmmm. This sounds good. Do you have this working?

Yes - since this afternoon ;-)

Unfortunatly I use aclocal 1.7 and do not have aclocal 1.4 to
regenerate the files - and using 1.7 would force newer autoconf :-(.

I tested the patch with handediting configure and aclocal.m4 and it
worked fine.  Can somebody else with the right tools test and commit
this for me, please?

Thanks,
Andreas

2003-06-14  Andreas Jaeger  <aj@suse.de>

	* acinclude.m4 (GLIBCPP_CONFIGURE_TESTSUITE): Make
	check-abi multilib aware.

============================================================
Index: libstdc++-v3/acinclude.m4
--- libstdc++-v3/acinclude.m4	14 Jun 2003 05:35:46 -0000	1.243
+++ libstdc++-v3/acinclude.m4	14 Jun 2003 14:45:13 -0000
@@ -2055,7 +2055,7 @@ AC_DEFUN(GLIBCPP_CONFIGURE_TESTSUITE, [
   GLIBCPP_CHECK_STDLIB_DECL_AND_LINKAGE_3(setenv)
 
   # Export file names for ABI checking.
-  baseline_file="${glibcpp_srcdir}/config/abi/${abi_baseline_pair}/baseline_symbols.txt"
+  baseline_file="${glibcpp_srcdir}/config/abi/${abi_baseline_pair}\$(MULTISUBDIR)/baseline_symbols.txt"
   AC_SUBST(baseline_file)
 
   dnl XXX move to configure.host?

-- 
 Andreas Jaeger, SuSE Linux AG, aj@suse.de, http://www.suse.de/~aj
  GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature