Re: fixing inlining warnings

[Mark Mitchell <mark at codesourcery dot com>]

On Thu, 2003-05-01 at 12:09, Benjamin Kosnik wrote:
> So, with the recent inlining fixes in the compiler, there are a huge
> number or warnings when building libstdc++. This only annoying, and
> doesn't change codegen. (From what I understand.)
> 
> There are two routes to fix this:
> 
> 1) remove -Winlining from the build
> 
> 2) fix up the code.
> 
> Two is obviously preferred, but more work. Below is a (partial, perhaps
> incomplete and duplicated) list of functions causing warnings.
> 
> Apparently this is now an issue on gcc and gcc-3_3-branch. 
> 
> Before this is fixed correctly, can it be verified that the current
> inlining strategy is not going to change much?

I'd hate to try to guess. :-)

I suspect that many of these functions are not being inlined due simply
to the fact that the functions they are being inlined into are already
"too large" according to the current hueristics.  An improvement on my
-Winline fix would be to say *why* the function isn't being inlined, but
I'm not likely to get to that any time soon.

> -- 
> Mark Mitchell <mark@codesourcery.com>
> CodeSourcery, LLC