This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Move pback members from basic_streambuf to basic_filebuf


Paolo Carlini wrote:
Andreas, can you please test the below??

If I don't hear from you in the next few hours probably
will commit it anyway, since I'm almost sure of its correctness
but I would appreciate a feedback from you.

Thanks!

Paolo,

Thanks for the quick reaction.

Well, there are some failures though.

E.g. 27_io/basic_ios/3.cc
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: expected unqualified-id^M
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: abstract declarator `long unsigned int' used as declaration^M
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: explicit instantiation of non-template `long unsigned int $_52'^M
compiler exited with status 1
output is:
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: expected unqualified-id^M
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: abstract declarator `long unsigned int' used as declaration^M
/Volumes/xufs/gcc-cvs/gcc/libstdc++-v3/testsuite/27_io/basic_ios/3.cc:135: error
: explicit instantiation of non-template `long unsigned int $_52'^M
I had to add the removed part again, but modified:


	std::basic_streambuf<gnu_char_type>::int_type
  --> 	std::basic_filebuf<gnu_char_type>::_S_pback_size;

Also, I'm not quite sure if you can remove the std::xxxx; <----- semicolon

You're the c++ expert!

I continue for a moment, then I'm away for an hour or 2.

Thanks,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]