This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Performance and memory usage improvements for stl_tree.h
On Wed, Feb 26, 2003 at 06:05:13PM +0100, Gawain Bolton wrote:
> Nathan Myers wrote:
> >On Sat, Feb 22, 2003 at 03:24:43PM +0100, Gawain Bolton wrote:
> >>This is an updated patch to improve stl_tree.h. It affects the
> >>std::map, std::multimap, std::set and std::multiset container types.
> >
> >I vote to put this one in immediately. The only think I'd fix along
> >the way is some of the comments that go beyond 80 columns.
>
> Thanks for your comments Nathan. I have fixed the problem concerning
> comments beyond 80 columns and removed the use of static_cast<> as this
> increased the size of generated code bloat and is therefore probably
> less efficient than a C style cast.
If a C-style cast produced different object code than the static_cast<>,
that probably indicates an error. We like static_cast<> because it's
easier to find with grep, and ugly enough that you try to avoid a need
to do it at all.
Nathan Myers
ncm at cantrip dot org