This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Fix filebuf_virtuals.cc for unsigned char platforms
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: mark at klomp dot org, pcarlini at unitus dot it
- Cc: jeroen dot dobbelaere at acunia dot com, libstdc++ at gcc dot gnu dot org, mark at wildebeest dot org
- Date: Thu, 6 Feb 2003 23:53:33 -0500 (EST)
- Subject: Re: [Patch] Fix filebuf_virtuals.cc for unsigned char platforms
- References: <3E42E387.1080008@unitus.it> <1044575613.21136.54.camel@elsschot>
> From: Mark Wielaard <mark@klomp.org>
>
> Hi,
>
> On Thu, 2003-02-06 at 23:36, Paolo Carlini wrote:
> > Kaveh, Jeroen, Mark, could you possibly test the below on your
> > favourite unsigned char platform and report?
>
> On powerpc-unknown-linux-gnu without the patch compiling this test
> gives:
>
> /home/mark/src/gcc33/gcc/libstdc++-v3/testsuite/27_io/filebuf_virtuals.cc: In static member function `static bool MyTraits::eq(char, char)':
> /home/mark/src/gcc33/gcc/libstdc++-v3/testsuite/27_io/filebuf_virtuals.cc:545: warning: comparison is always true due to limited range of data type
> /home/mark/src/gcc33/gcc/libstdc++-v3/testsuite/27_io/filebuf_virtuals.cc:546: warning: comparison is always true due to limited range of data type
>
> With the patch applied it compiles cleanly.
> This was on the 3.3 branch and compiled by hand.
I applied the patch and ran "make -k check-target-libstdc++-v3" on
mips-sgi-irix6.5. The failure went away.
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu