This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: verbose terminate() on by default, pass 2
- From: Nathan Myers <ncm-nospam at cantrip dot org>
- To: libstdc++ at gcc dot gnu dot org
- Date: Tue, 24 Dec 2002 21:40:31 -0800
- Subject: Re: verbose terminate() on by default, pass 2
- References: <20021224222318.A15423@disaster.jaj.com>
Phil,
On Tue, Dec 24, 2002 at 10:23:18PM -0500, Phil Edwards wrote:
> This takes into account some suggestions:
>
> - verbose termination implementation in libsupc++, not libstdc++
> - verbose termination implementation in its own translation unit
> - handler definitions in their own translation units
> - no fprintf
> - more verbose text, no `...' quoting
Looks marvelous. Just a couple of comments...
> +++ src/vterminate.cc 24 Dec 2002 00:45:14 -0000
> +
> using namespace std;
> using namespace abi;
Isn't the name "abi" reserved for users?
> + char const *w = exc.what();
> + type_info *t = __cxa_current_exception_type();
> + char const *name = t->name();
> + char *dem = 0;
> + catch (exception &exc)
> + char const *w = exc.what();
This is C++ code. Shouldn't we have C++-style declarations?
Nathan Myers
ncm-nospam@cantrip.org