This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: top-level configure: preserve quotes in arguments (Was: Re: [libstdc++] libstdc++/7691, pass -Wabi, sanity checks)
- From: Phil Edwards <phil at jaj dot com>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: Alexandre Oliva <aoliva at redhat dot com>, johnm at falch dot net, manfredh at redhat dot com, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 16 Oct 2002 21:49:18 -0400
- Subject: Re: top-level configure: preserve quotes in arguments (Was: Re: [libstdc++] libstdc++/7691, pass -Wabi, sanity checks)
- References: <20020828221458.A26047@disaster.jaj.com> <20020828214244.09bde535.bkoz@redhat.com> <20020829114329.A30164@disaster.jaj.com> <1030637067.1116.13.camel@merkur.hollstein.net> <20020829093904.41494001.bkoz@redhat.com> <20020829160812.A969@disaster.jaj.com> <20020830184800.GA18722@kahikatea.falch.net> <or1y8dphdi.fsf@free.redhat.lsd.ic.unicamp.br> <20020904152744.06ae7143.bkoz@redhat.com>
Coming back to this after too long...
On Wed, Sep 04, 2002 at 03:27:44PM -0500, Benjamin Kosnik wrote:
>
> > Hmm... There's one thing I dislike about your patch, which is that it
> > turns --enable-cxx-flags= into --enable-cxx-flags (with an implicit
> > =yes). I'd rather set addoption to the entire string to be added to
> > $arguments, quoted if necessary.
>
> I agree. Thoughts? Phil, what do you think? Does this look ok?
>From what I can tell it looks okay. Certainly GLIBCPP_ENABLE_CXX_FLAGS
could be modified to accept and ignore a default =yes, but Alexandre's
points should probably be addressed. The PR remains open, after all. :-)
Phil
--
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
- Edsger Dijkstra, 1930-2002