This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: More fallout from global.cc namespace changes
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Sat, 12 Oct 2002 21:08:02 -0500
- Subject: Re: More fallout from global.cc namespace changes
- Organization: Red Hat / Chicago
- References: <20021012234505.46359.qmail@web21407.mail.yahoo.com>
> The symbols are defined in namespace __gnu_cxx in globals.cc but declared
> in namespace std in stl_threads.h.
Whoops.
> The following fixes by, declaring in __gnu_cxx is stl_threads.h. An
> alternative is to revert part of the change and define these in namespace
> std in globals.cc, as before.
It would be nice to keep all implementation bits in globals.cc out of
namespace std.
You'll need to bump the date on the stl_threads.h copyright notice. You
could explicitly qualify the __gnu_cxx bits, or inject the names for
struct _STL_mutex_lock only, instead of a global injection in this
include file.
Loren? This looks like the only remaining damage on BSD, correct? Thinks
look ok on your testruns, threads excepted.
-benjamin