This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to libstc++: Remove strdup from locale_facets.tcc


Phil Edwards wrote:

On Mon, Sep 09, 2002 at 08:30:07PM -0500, Loren James Rittle wrote:

In article <20020909230558.46315.qmail@web14501.mail.yahoo.com> you write:

2002-09-10  Danny Smith  <dannysmith@users.sourceforge.net>

	* include/bits/locale_facets.tcc (__convert_from_v):
	Replace strdup with ANSI malloc and strcpy.

Approved for mainline.  Concurrently, approved for 3.2.X branch since
it is a regression from libstdc++-v2 as shipped with gcc 2.95.3.

And if you haven't checked it in before this email reaches you, please
change 'ANSI' to 'ISO' in your changelog entry.

... and if this is the right fix, then you may want to massage *all* the other
strdup present in the library too:

./config/locale/generic/c_locale.cc:123:
./config/locale/generic/c_locale.cc:163:
./config/locale/generic/c_locale.cc:185:
./config/locale/generic/time_members.cc:54:
./config/locale/generic/time_members.cc:137:
./config/locale/gnu/messages_members.cc:52:
./config/locale/gnu/messages_members.cc:72:
./config/locale/gnu/monetary_members.cc:342:
./config/locale/gnu/monetary_members.cc:441:
./config/locale/gnu/time_members.cc:58:
./config/locale/gnu/time_members.cc:211:
./config/os/gnu-linux/ctype_noninline.h:50:
./config/os/gnu-linux/ctype_noninline.h:78:
./config/os/gnu-linux/ctype_noninline.h:108:

Ciao, Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]