This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Add ia64-linux and alphaev6-linux baseline_symbols.txt
> > a) it calls sort without explicitely saying what locale it wants to be
> > sorted in, i686-pc-linux-gnu files have been apparently sorted with
> > LC_ALL=en_US or other locale with identical collation.
> > I've followed this, but maybe it would be better to use C locale,
> > ie. s/sort/LC_ALL=C sort/ and resort the files.
>
> Might be useful, yes. (Do we really need to sort the lists at all, given
> that we're storing them in maps?)
We should probably either sort inside abi-check, and use the "C" locale,
or do as Jakub suggests.
> > b) maybe make abi-check should be more liberate about platform tripples,
> > e.g. i386-pc-linux-gnu ought to be always identical to
> > i686-pc-linux-gnu which should be identical i386-redhat-linux or
> > i586-suse-linux or whatever. Similarly it shouldn't matter if the
> > build is alphaev67 or alphaev5 or alpha, etc.
> > But it matters if the build is sparc64- vs. sparc-...
>
> Absolutely; this was brought up before, and some renaming is in order.
> (I plan to do this all at once, and soonish.)
Yeah.
I think you are ok to check in Jakub. The renaming of the config/abi
directories can happen afterwards.
Thanks!
-benjamin