This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] V3 PATCH: Add support for aligned storage


> 2002-08-01  Gabriel Dos Reis  <gdr@nerim.net>
> 
> 	* include/ext/storage: New file.
> 	* include/bits/storage.h: Like wise.
> 	* src/globals.cc (std): #include "bits/storage.h".  Use
> 	aligned_storage<> instead of explicit manual type alignment.
> 	* include/Makefile.am (ext_headers): Add ext/storage
> 	(bits_headers): Add bits/storage.h
> 	* include/Makefile.in: Regenerate.

You need to kill the include/bits/storage.h file and move everything to
/include/ext/storage.

There should be nothing in 

> + namespace __gnu_cxx

in include/bits

Other than that, looks good. Did you see the GNATS bug about alignment
on 16 byte boundaries, and Jakub's response that says this is not
possible for sizes above 8? You might want to document this, and test
the limits of aligned_storage.

In fact, you should test this period.

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]