This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [RFC] V3 PATCH: Add support for aligned storage
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Gabriel Dos Reis <gdr at nerim dot net>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Aug 2002 09:17:30 -0700
- Subject: Re: [RFC] V3 PATCH: Add support for aligned storage
- Organization: Red Hat / Chicago
- References: <m3fzxzj5j5.fsf@uniton.integrable-solutions.net>
- Reply-to: bkoz at redhat dot com
> 2002-08-01 Gabriel Dos Reis <gdr@nerim.net>
>
> * include/ext/storage: New file.
> * include/bits/storage.h: Like wise.
> * src/globals.cc (std): #include "bits/storage.h". Use
> aligned_storage<> instead of explicit manual type alignment.
> * include/Makefile.am (ext_headers): Add ext/storage
> (bits_headers): Add bits/storage.h
> * include/Makefile.in: Regenerate.
You need to kill the include/bits/storage.h file and move everything to
/include/ext/storage.
There should be nothing in
> + namespace __gnu_cxx
in include/bits
Other than that, looks good. Did you see the GNATS bug about alignment
on 16 byte boundaries, and Jakub's response that says this is not
possible for sizes above 8? You might want to document this, and test
the limits of aligned_storage.
In fact, you should test this period.
-benjamin