This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++] Problems with deques (patch included)
- From: Gabriel Dos Reis <gdr at codesourcery dot com>
- To: Peter Schmid <schmid at snake dot iap dot physik dot tu-darmstadt dot de>
- Cc: <libstdc++ at gcc dot gnu dot org>, <gcc-patches at gcc dot gnu dot org>
- Date: 08 Jul 2002 07:47:36 +0200
- Subject: Re: [libstdc++] Problems with deques (patch included)
- Organization: CodeSourcery, LLC
- References: <Pine.LNX.4.30.0207080201570.26629-100000@snake.iap.physik.tu-darmstadt.de>
Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de> writes:
[...]
| --- libstdc++-v3/include/bits/stl_deque.h Mon Jul 8 01:55:10 2002
| *************** protected:
| *** 385,394 ****
| _M_deallocate_map(_Tp** __p, size_t __n)
| { _M_map_allocator.deallocate(__p, __n); }
|
| - _Tp** _M_map;
| - size_t _M_map_size;
| allocator_type _M_node_allocator;
| _Map_allocator_type _M_map_allocator;
| };
|
| /// @if maint Specialization for instanceless allocators. @endif
| --- 385,394 ----
| _M_deallocate_map(_Tp** __p, size_t __n)
| { _M_map_allocator.deallocate(__p, __n); }
|
| allocator_type _M_node_allocator;
| _Map_allocator_type _M_map_allocator;
| + _Tp** _M_map;
| + size_t _M_map_size;
| };
This unncessarily breaks ABI. It is better to reorder the
base-initialiser-list insteads of the data member declaration.
Thanks,
-- Gaby