This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Tighten length error check in string::replace

From: Paolo Carlini <pcarlini at unitus dot it>
To: Paolo Carlini <pcarlini at unitus dot it>
Cc: bkoz at redhat dot com, libstdc++ at gcc dot gnu dot org
Date: Fri, 26 Apr 2002 01:24:27 +0200
Subject: Re: [PATCH] Tighten length error check in string::replace
References: <3CC71B5B.7090103@unitus.it> <20020425091200.273b9411.bkoz@redhat.com> <3CC85715.3030200@unitus.it> <20020425152658.009763cf.bkoz@redhat.com> <3CC88D75.8050804@unitus.it>

Paolo Carlini wrote:

> Notice, moreover, that (my bad!) the current test (__size - __n1 > 
> this->max_size() - __n2) for sure is not self-consistent, since both 
> __size and __n1 are unsigned quantities and therefore if the user 
> specifies __n1 > __size (he can, is up to the library to fold the 
> value) false positives may result from the comparison. 

Thinking more about this, I'm finding this bug pretty serious and would 
even ask for having it 3.1.0, if still possible.

Thanks again,
Paolo.

Follow-Ups:
- Re: [PATCH] Tighten length error check in string::replace
  - From: Paolo Carlini

References:
- [PATCH] Tighten length error check in string::replace
  - From: Paolo Carlini
- Re: [PATCH] Tighten length error check in string::replace
  - From: Benjamin Kosnik
- Re: [PATCH] Tighten length error check in string::replace
  - From: Paolo Carlini
- Re: [PATCH] Tighten length error check in string::replace
  - From: Benjamin Kosnik
- Re: [PATCH] Tighten length error check in string::replace
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]