This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix collate_members_char[wchar_t].cc
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Paolo Carlini <pcarlini at unitus dot it>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Thu, 14 Mar 2002 10:57:12 -0800 (PST)
- Subject: Re: [PATCH] Fix collate_members_char[wchar_t].cc
> Hi Benjamin. Well, I think VERIFY(i2 == +1) (or -1 in the other testcase) is
> better, in that, whereas the value computed by string::compare is /not/ normalized,
> that of collate::compare /is/ normalized (it wasn't in v3, wrongly, before mine and
> Uli's recent patch)
Sorry. I'm reading mail out-of-order.
string::compare results shouldn't assume normalization, so > 0, < 0
collate::compare should assume normalization, so -1, 1
As long as the above is done consistently, I'm for it.
-benjamin