Re: [RFC] 27_io/ios_manip_basefield.cc

[Paolo Carlini <pcarlini at unitus dot it>]

Benjamin Kosnik wrote:

>>ither case (grouping or not) we can rather easily, IMO, get rid the failure, by
>>changing _M_widen_int or the projected output.
>>
>
>Right. 
>
>
>I think both will have to be changed, as hex and oct output should be
>grouped, and the current code is not consistent with the language in the
>standard. I think other testsuite files will also be impacted (operator >>
>void* comes to mind.)
>

Thanks Benjamin for your feedback.
I completely agree with you. In the next couple of days I will work on 
_M_widen_int (and the corresponding projected output) to enable grouping 
for hexs and octs. The only tricky point is that we cannot simply change 
the condition if (__grouping.size() && __dec) to (__grouping.size())) 
since, as is, __add_grouping is not able to deal correctly with numbers 
beginning with 0x or 0X or 0 (when showbase is true, I mean). But I can 
work out this.
As regards the impact on other testsuite files, I will see what breaks 
and in case I'm not able to sort out the problem I will ask for your help.

Ciao, Paolo.