This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] 27_io/ios_manip_basefield.cc



> The only delicate point seems to be that regarding the grouping, which we
> currenlty ignore *on purpose* for octs and hexs, locale_facets.tcc line 733:

Right.

> It would be easy to change this behaviour. A few other implementations (STLPort,
> Metro, Dinkum) in fact seems to prefer doing the grouping for hexs and octs too.
> But Benjamin mentioned the LWG, perhaps there is a defect regarding this? I
> could not find one. I'm puzzled since it seems to me that the current standard
> does not distinguish dec from hex and oct for grouping (22.2.2.2.2,16).

Right.

I was talking about a discussion on the list. Thanks to Martin, I have the 
message id: c++std-lib-8915

(c++std-ping@research.att.com, message body "send c++std-lib-8915")

It doesn't look like it's made it to a DR yet.

> Either case (grouping or not) we can rather easily, IMO, get rid the failure, by
> changing _M_widen_int or the projected output.

Right. 


I think both will have to be changed, as hex and oct output should be
grouped, and the current code is not consistent with the language in the
standard. I think other testsuite files will also be impacted (operator >>
void* comes to mind.)

Thanks,
benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]