This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix libstdc++/5708


On Mon, Feb 18, 2002 at 11:51:54PM +0100, Paolo Carlini wrote:
> Nathan Myers wrote:
> 
> > 2002-02-18  Paolo Carlini  <pcarlini@unitus.it>:
> > >
> > >         libstdc++/5708
> > >         * include/bits/locale_facets.tcc (money_put::do_put):
> > >         For the space field use __fill instead of ' ', uniformly.
> > >         * testsuite/22_locale/money_put_members_char.cc:
> > >         Add test05 distilled from PR.
> > >         (test01-02-03): Trim some '*' to ' '.
> > >         * testsuite/22_locale/money_put_members_wchar_t.cc: Ditto.
> >
> > I don't agree that we have license to assume "space" may be replaced
> > with __fill in the output format. The subject has not (to my
> > knowledge) been reported as a Defect to the committee. This change
> > strikes me as a source of interoperability problems, as sensible as
> > it might seem otherwise.
> >
> > What other implementation does it?
>
> Metrowerks does it. Otherwise, as I reported in my first message, a
> different implementation do not output a "space" at all for the space
> field if !(internal formatting and len < width).

I don't see any support in the standard for failing to output the space
under any circumstances.  Maybe it should be allowed/required if the 
currency symbol is being suppressed.  That's an idea for a defect report,
though, not for code.

Nathan Myers
ncm at cantrip dot org


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]