This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Update backward/algo.h
- From: Nathan Myers <ncm-nospam at cantrip dot org>
- To: libstdc++ at gcc dot gnu dot org
- Date: Sun, 30 Dec 2001 08:22:11 +0000
- Subject: Re: [PATCH] Update backward/algo.h
- References: <3C2ECB3A.74AC4FED@unitus.it>
On Sun, Dec 30, 2001 at 09:07:22AM +0100, Paolo Carlini wrote:
> this, rather harmless patch IMHO, updates backward/algo.h in the
> light of the recent changes to include/bits/stl_algo.h and the new
> include/ext/algorithm. Tested i686-pc-linux-gnu.
>
> *** libstdc++-v3-orig/include/backward/algo.h Wed Jun 27 19:09:52 2001
> --- libstdc++-v3/include/backward/algo.h Sun Dec 30 09:00:49 2001
> ***************
> *** 62,67 ****
> --- 62,68 ----
> #include "iterator.h"
> #include <bits/stl_algo.h>
> #include <bits/stl_numeric.h>
> + #include <ext/algorithm>
Unless I'm confused (which is quite possible), this violates the
in-library header inclusion rule that forbids any header from
sub-including another header whose name has no suffix.
http://gcc.gnu.org/onlinedocs/libstdc++/17_intro/HEADER_POLICY
I wrote the policy back in '98. As noted, much of the motivation
for the rule was GNU Make's (and others') eagerness to delete files
that have no suffix, in the event of a fatal signal.
It may be necessary to give ext/algorithm a suffix, or to make it
sub-include ext/bits/algorithm.h, and make algo.h include that
directly.
Nathan Myers
ncm at cantrip dot org