This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++ patch] Check for __builtins in std_cmath.h
- From: Gabriel Dos Reis <gdr at codesourcery dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, <libstdc++ at gcc dot gnu dot org>, David Edelsohn <dje at watson dot ibm dot com>
- Date: 29 Dec 2001 06:25:45 +0100
- Subject: Re: [libstdc++ patch] Check for __builtins in std_cmath.h
- Organization: CodeSourcery, LLC
- References: <Pine.LNX.4.33.0112282032380.582-100000@www.eyesopen.com>
Roger Sayle <roger@eyesopen.com> writes:
| This patch was originally developed as a possible solution to the
| high priority PR libstdc++/3184. Just my luck, PR 3184 was closed
| earlier today whilst this patch was being regression tested. It
| does however protect against using __builtin functions on targets
| that don't support them.
I think we already discussed that matter in the past. If a target
does not support a __builtin_xxx, then it falls back to a library xxx
definition. libmath/stubs.c is the right place to put missing xxx
definitions.
[...]
| Is this OK for mainline, even though it no longer has a PR?
No.
Thanks,
-- Gaby
CodeSourcery, LLC http://www.codesourcery.com