Re: [PATCH] For SGI stl_algo.h extensions (was: Re: [RFC] Moving apart SGI extensions)

[Gabriel Dos Reis <gdr at codesourcery dot com>]

Paolo Carlini <pcarlini@unitus.it> writes:

| Gabriel Dos Reis wrote:
| 
| > Why not just call it algorithm.h, or algorithm?  After all, it is in
| > the separate directory.
| 
| Right: algorithm is ok. #include <ext/algorithm> is nice! I'm correcting this.
| For the include guard I propose _EXT_ALGORITHM, however. What do you think?

I don't think that is necessary: By the point the user says 
#include <ext/algorithm>, he is already asking for nonstandard
features and I don't think we should go another macro step further in
order to have the requested functionnalities in.

| > Apart from that, the patch looks OK for me although I don't know
| > whether he copyright notice is correct or not.
| 
| Hummm.
| To be safe, most probably we should add both HP and SGI copyrights too, as currently
| happens at the beginning stl_algo.h.

Thanks!

-- Gaby
CodeSourcery, LLC                       http://www.codesourcery.com