This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: V3 PATCH: Fix PR3988
- To: Mark Mitchell <mark at codesourcery dot com>
- Subject: Re: V3 PATCH: Fix PR3988
- From: Benjamin Kosnik <bkoz at redhat dot com>
- Date: Tue, 14 Aug 2001 16:02:51 -0700 (PDT)
- cc: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>, Gabriel Dos Reis <gdr at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
> > Well, a patch for config/os/gnu-linux/bits/os_defines.h or a solution
> > like the 386 one that Mark did?
Please try to keep this cpu-specific stuff out of os-specific headers.
> I think the CPU-specific way is better, in general. I think that David
> asked me about doing that way, originally, and I chickened out; either
> way does get the job done.
Only, putting the cpu-stuff in config/cpu actually makes sense. This
avoids confusion, and makes future maintenance enjoyable.
> If most of the systems on PowerPC do this the same way, it makes
> sense to use the CPU-specific way. I'd prefer not to change existing
> configurations, though, if we can help it; there's no need to introduce
> risk on AIX, for example, if things already work correctly there.
Please do this correctly on the trunk, at least.
-benjamin